<html>
<head><meta charset="utf-8"><title>Weekly perf check · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html">Weekly perf check</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="198708926"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198708926" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198708926">(May 25 2020 at 23:37)</a>:</h4>
<p>Hi. I have started doing a weekly check of <a href="http://perf.rust-lang.org">perf.rust-lang.org</a> for improvements/regressions. I've done it twice now.</p>



<a name="198708935"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198708935" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198708935">(May 25 2020 at 23:37)</a>:</h4>
<p>This is something I've done occasionally in the past, but I think it's a good idea to have a more consistent check.</p>



<a name="198708982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198708982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198708982">(May 25 2020 at 23:38)</a>:</h4>
<p>Here are the results for the one I just did today.<br>
Improvements</p>
<ul>
<li>
<p>52b6   ReScope improvement  <a href="https://github.com/rust-lang/rust/issues/72362">#72362</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=3137f8e2d141d7d7c65040a718a9193f50e1282e&amp;end=52b605c8cb2f730e607de0777a694cd1b9bb3e15&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=3137f8e2d141d7d7c65040a718a9193f50e1282e&amp;end=52b605c8cb2f730e607de0777a694cd1b9bb3e15&amp;stat=instructions:u</a></p>
</li>
<li>
<p>7f79e  Dumb NRVO   <a href="https://github.com/rust-lang/rust/issues/72205">#72205</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=963bf528292d8f97104515e32908e30c2467b6a8&amp;end=7f79e98c0356642db62e5113327e436c951e843d&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=963bf528292d8f97104515e32908e30c2467b6a8&amp;end=7f79e98c0356642db62e5113327e436c951e843d&amp;stat=instructions:u</a></p>
</li>
</ul>
<p>Regressions</p>
<ul>
<li>
<p>82911b LLVM 10 regression   <a href="https://github.com/rust-lang/rust/issues/67759">#67759</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=0aa6751c19d3ba80df5b0b02c00bf44e13c97e80&amp;end=82911b3bba76e73afe2881b732fe6b0edb35d5d3&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=0aa6751c19d3ba80df5b0b02c00bf44e13c97e80&amp;end=82911b3bba76e73afe2881b732fe6b0edb35d5d3&amp;stat=instructions:u</a></p>
</li>
<li>
<p>d9417  Predicate interning regression    <a href="https://github.com/rust-lang/rust/issues/72055">#72055</a><br>
<a href="https://perf.rust-lang.org/compare.html?start=9310e3bd4f425f84fc27878ebf2bda1f30935a63&amp;end=d9417b385145af1cabd0be8a95c65075d2fc30ff&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=9310e3bd4f425f84fc27878ebf2bda1f30935a63&amp;end=d9417b385145af1cabd0be8a95c65075d2fc30ff&amp;stat=instructions:u</a></p>
</li>
</ul>



<a name="198709020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709020">(May 25 2020 at 23:39)</a>:</h4>
<p>When I find a notable change, I add a comment to the relevant PR, which is a good start. But I'd like to also have some kind of ongoing log. Any suggestions for where to put this? One idea is to put it in This Week in Rust, which would certainly provide high visibility.</p>



<a name="198709031"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709031" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709031">(May 25 2020 at 23:39)</a>:</h4>
<p>(I just pinged Nell about that on Slack, she said she'll get back to me tomorrow)</p>



<a name="198709079"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709079" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709079">(May 25 2020 at 23:40)</a>:</h4>
<p>I'd also like to have a "how I do it" page, for transparency, and to allow others to take over when I'm on PTO, etc.</p>



<a name="198709088"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709088" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709088">(May 25 2020 at 23:40)</a>:</h4>
<p>A bit like this page we have for Firefox crash triage: <a href="https://wiki.mozilla.org/NightlyCrashTriage">https://wiki.mozilla.org/NightlyCrashTriage</a></p>



<a name="198709090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709090">(May 25 2020 at 23:41)</a>:</h4>
<p>I don't know where that might live.</p>



<a name="198709171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709171">(May 25 2020 at 23:43)</a>:</h4>
<p>I'm happy to hear suggestions and thoughts about this.</p>



<a name="198709177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709177">(May 25 2020 at 23:43)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116009">@nikomatsakis</span></p>



<a name="198709195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709195">(May 25 2020 at 23:43)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116122">@simulacrum</span></p>



<a name="198709270"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709270" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709270">(May 25 2020 at 23:45)</a>:</h4>
<p>Maybe we put it on perf directly? I'd be happy to have some simple file format or whatever (maybe just markdown?)</p>



<a name="198709324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709324">(May 25 2020 at 23:46)</a>:</h4>
<p>I imagine that once we have a log putting a link to it in TWIR would work well, or extracting pieces of it</p>



<a name="198709760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198709760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198709760">(May 25 2020 at 23:58)</a>:</h4>
<p>I've also been checking this in an ad-hoc manner. Having it become a dedicated weekly task would be great, especially if we had some procedure for when to open an issue about or temporarily revert PRs with bad performance problems.</p>



<a name="198710268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198710268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198710268">(May 26 2020 at 00:10)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Markdown is fine, we could just have a directory in rustc-perf and then view it via GitHub?</p>



<a name="198710330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198710330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198710330">(May 26 2020 at 00:12)</a>:</h4>
<p>The instructions could also be done that way</p>



<a name="198710345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198710345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198710345">(May 26 2020 at 00:13)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I'll file a PR for this later</p>



<a name="198710350"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198710350" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198710350">(May 26 2020 at 00:13)</a>:</h4>
<p>yeah that works too</p>



<a name="198710353"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198710353" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198710353">(May 26 2020 at 00:13)</a>:</h4>
<p>(We can also eventually render it I guess, but I agree that's less important)</p>



<a name="198714938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198714938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198714938">(May 26 2020 at 02:16)</a>:</h4>
<p>First draft: <a href="https://github.com/rust-lang/rustc-perf/pull/662">https://github.com/rust-lang/rustc-perf/pull/662</a></p>



<a name="198715440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198715440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198715440">(May 26 2020 at 02:30)</a>:</h4>
<p>Maybe I should move the logs into a separate file</p>



<a name="198715446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198715446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198715446">(May 26 2020 at 02:31)</a>:</h4>
<p>I could do one file per year, have a <code>2020-log.md</code> file</p>



<a name="198811902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198811902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198811902">(May 26 2020 at 19:44)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120989">Nicholas Nethercote</span> <a href="#narrow/stream/131828-t-compiler/topic/Weekly.20perf.20check/near/198709031">said</a>:</p>
<blockquote>
<p>(I just pinged Nell about that on Slack, she said she'll get back to me tomorrow)</p>
</blockquote>
<p>We have a slack?</p>



<a name="198811978"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198811978" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198811978">(May 26 2020 at 19:45)</a>:</h4>
<p>It would be cool to have it on <code>Inside Rust</code> blog (EDIT: I mean the perf updates)</p>



<a name="198812601"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198812601" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> lqd <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198812601">(May 26 2020 at 19:50)</a>:</h4>
<p>probably internal to mozilla :)</p>



<a name="198814776"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198814776" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198814776">(May 26 2020 at 20:06)</a>:</h4>
<p>It seems <span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> like this is a great service, and maybe the <a class="stream" data-stream-id="227806" href="/#narrow/stream/227806-t-compiler.2Fwg-prioritization">#t-compiler/wg-prioritization</a> report can incorporate this information for the weekly meeting?</p>



<a name="198814793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198814793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198814793">(May 26 2020 at 20:07)</a>:</h4>
<p>(cc <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span>)</p>



<a name="198821942"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198821942" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198821942">(May 26 2020 at 21:08)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> yes, this is what I was talking also with <span class="user-mention silent" data-user-id="116122">simulacrum</span> and others about coordinating this kind of efforts <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="198822012"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198822012" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198822012">(May 26 2020 at 21:09)</a>:</h4>
<p>we are right now going over perf too, but if <span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> is doing that and more focused on it, it may not make a lot of sense if we do the same as part of a completely different meeting and less focused on this part</p>



<a name="198826507"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Weekly%20perf%20check/near/198826507" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Weekly.20perf.20check.html#198826507">(May 26 2020 at 21:55)</a>:</h4>
<p>yeah I was just imagining maybe pointing at it and looking for any key points to raise  during meeting</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>